Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lodash to > 4.17.12 #4730

Closed
Lavioli opened this issue Jul 16, 2019 · 5 comments
Closed

Update lodash to > 4.17.12 #4730

Lavioli opened this issue Jul 16, 2019 · 5 comments
Labels
type: duplicate This issue or pull request already exists

Comments

@Lavioli
Copy link

Lavioli commented Jul 16, 2019

running npm audit shows a Prototype Pollution vulnerability, please update the lodash library to verions highter than 4.17.12

https://www.npmjs.com/advisories/1065

Current behavior:

Screen Shot 2019-07-16 at 9 08 44 AM

Desired behavior:

Steps to reproduce: (app code and test code)

Versions

cypress 3.4.0

cypress 3.4.0
Mac OSX
Chrome

@Evanht
Copy link

Evanht commented Jul 16, 2019

fix already merged in develop, but not released yet :( #4684

@flotwig
Copy link
Contributor

flotwig commented Jul 16, 2019

Duplicate of #4699

@flotwig flotwig marked this as a duplicate of #4699 Jul 16, 2019
@flotwig flotwig closed this as completed Jul 16, 2019
@flotwig flotwig added the type: duplicate This issue or pull request already exists label Jul 16, 2019
@jennifer-shehane
Copy link
Member

The code for this is done in #4709, but this has yet to be released. We'll update this issue and reference the changelog when it's released.

You can run npm audit fix to fix the 'vulnerable' dependencies.

But also Cypress is immune to most if not all security vulnerabilities because its locally run software - not a web server hosted in the cloud, so this security issue doesn't even apply and is low priority for us.

@Lavioli
Copy link
Author

Lavioli commented Jul 18, 2019

Thanks for the prompt response :)

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2019

Released in 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants