Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NO_PROXY=<-loopback>, always have NO_PROXY=localhost otherwise #4780

Closed
flotwig opened this issue Jul 22, 2019 · 2 comments · Fixed by #4800
Closed

Support NO_PROXY=<-loopback>, always have NO_PROXY=localhost otherwise #4780

flotwig opened this issue Jul 22, 2019 · 2 comments · Fixed by #4800
Assignees
@flotwig
Labels
topic: network

Comments

@flotwig
Copy link
Contributor

flotwig commented Jul 22, 2019

Current behavior:

NO_PROXY has a pitfall where users will intuitively want to do NO_PROXY=some-external-site.net, but this also means that localhost will be sent through the proxy, which almost never makes any sense to do.

Desired behavior:

Always consider localhost to be in NO_PROXY unless <-loopback> is included (same contract as Chrome's --proxy-bypass-list

NO_PROXY=example.com => NO_PROXY=localhost,127.0.0.1,example.com
NO_PROXY=example.com,<-loopback> => NO_PROXY=example.com
@flotwig flotwig self-assigned this Jul 22, 2019
@flotwig flotwig mentioned this issue Jul 24, 2019
Merged
3 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Aug 2, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Aug 2, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 2, 2019

The code for this is done in cypress-io/cypress#4800, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@bjowes bjowes mentioned this issue Oct 29, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Nov 9, 2019
Closed
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flotwig flotwig

Labels
topic: network
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support NO_PROXY=<-loopback>, always have NO_PROXY=localhost otherwise cypress-io/cypress
1 participant
@flotwig