Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce visual testing process for internal development of Desktop GUI #4983

Closed
jennifer-shehane opened this issue Aug 14, 2019 · 3 comments · Fixed by #6421
Closed

Introduce visual testing process for internal development of Desktop GUI #4983

jennifer-shehane opened this issue Aug 14, 2019 · 3 comments · Fixed by #6421
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory process: contributing Related to contributing to the Cypress codebase process: tests Related to our internal tests type: chore Work is required w/ no deliverable to end user

Comments

@jennifer-shehane
Copy link
Member

Current behavior:

There was a recent css change made to the desktop-gui package of Cypress that caused some unexpected changes to the design/css of the desktop-gui.

Original PR: #4737
Following breaking changes (that we know of): #4959 #4912 #4888 #4795

The problem is that none of our internal tests caught these issues. They were only found after using the Desktop-GUI manually within development. So, it's possible there is still some stuff that's broken.

Desired behavior:

Introduce a process into the Cypress development team to test visual changes in our own desktop-gui package.

Hopefully, after vetting and solidifying a process, we can expand this out to our other visual components, the runner and reporter packages.

This will also provide a great opportunity to put ourselves in the shoes of users of Cypress (like ourselves) so we can define the problem set and look through the solutions out there.

@jennifer-shehane jennifer-shehane added pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory process: tests Related to our internal tests process: contributing Related to contributing to the Cypress codebase stage: needs investigating Someone from Cypress needs to look at this type: chore Work is required w/ no deliverable to end user labels Aug 14, 2019
@jennifer-shehane jennifer-shehane changed the title Introduce screenshot diffing process for internal development of Desktop GUI Introduce visual testing process for internal development of Desktop GUI Aug 14, 2019
@bahmutov
Copy link
Contributor

I am feeling this - trying to add Experiments block to the Settings tab, the entire communication is back and forth via screenshots in #6265

I want to start with a few Percy screenshots for the Settings tab and this will add a visual workflow to the PR reviews. Probably we can start with a single project for now (and not divide per package).

@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs investigating Someone from Cypress needs to look at this labels Feb 11, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Mar 17, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Mar 17, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 17, 2020

The code for this is done in cypress-io/cypress#6421, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@jennifer-shehane
Copy link
Member Author

Released.

This comment thread has been locked as resolved.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory process: contributing Related to contributing to the Cypress codebase process: tests Related to our internal tests type: chore Work is required w/ no deliverable to end user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants