3.5.0 cy.click() behavior change caused broken tests

[leimd]

Current behavior:

With the update to 3.5.0, Cypress has stopped working with Select 2 library, when click() is called on the drop down element, no drop down is shown. @rakhid and I have made a sample test in Cypress and recorded video to show the problem.

Video Recording 3.5

Desired behavior:

When triggering click on the drop down element, a drop down should be shown Video Recording 3.4

Steps to reproduce: (app code and test code)

Here is a sample repo that we made to show the bug, there are two branches: cypress-34 and cypress-35 which has Cypress 3.4.0 and Cypress 3.5.0 in their package.json respectively. By checking out the respective branch and run npx cypress run, you can recreate the bug.

Versions

Cypress 3.5.0
Browser: Chrome & Electron

[leimd]

More Notes from my investigation

It seems that this is how it works in 3.4:
in click.js , x and y coordinates are determined, and then a $actionability.verify (...) is returned.

In actionability.coffee, in the verify method, at line 263:
ensureElIsNotCovered(cy, win, $el, coords.fromViewport, options, _log, onScroll) is triggered,
inside ensureElIsNotCovered , eventually this is executed, which subsitutes the element to the deepest element that we are about to interact with and let the events bubble up.

ensureDescendents = (fromViewport) ->
    ## figure out the deepest element we are about to interact
    ## with at these coordinates
    $elAtCoords = getElementAtPointFromViewport(fromViewport)

, what's behind getElementAtPointFromViewport is doc.elementFromPoint(x, y) which

[jennifer-shehane]

I can confirm that the provided repo passes in 3.4.1 and fails in 3.5.0 https://github.com/leimd/cypress-bug-demo

[jennifer-shehane]

There's a PR open to fix this here: #5496

[leimd]

Thanks @jennifer-shehane !

[cypress-bot]

The code for this is done in cypress-io/cypress#5496, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

The code for this is done in cypress-io/cypress#5496, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 3.6.0.