Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build separate 32bit and 64bit builds for Windows, don't ship ffmpeg twice #716

Closed
brian-mann opened this issue Oct 10, 2017 · 3 comments · Fixed by #3877
Closed

Build separate 32bit and 64bit builds for Windows, don't ship ffmpeg twice #716

brian-mann opened this issue Oct 10, 2017 · 3 comments · Fixed by #3877
Assignees
@flotwig
Labels
OS: windows process: build Related to our internal build process type: chore Work is required w/ no deliverable to end user

Comments

@brian-mann
Copy link
Member

Currently we only build 32bit Windows, but we ship two versions of ffmpeg for both 32bit and 64bit Windows.

This inflates the binary by almost 100mb O_O.

Need to build separate Windows arch. We've already updated the CLI and the download server to account for this.
@cypress-bot cypress-bot bot added the stage: proposal 💡 No work has been done of this issue label Feb 19, 2019
@jennifer-shehane jennifer-shehane added the type: chore Work is required w/ no deliverable to end user label Feb 19, 2019
@cypress-bot cypress-bot bot added stage: ready for work The issue is reproducible and in scope and removed stage: proposal 💡 No work has been done of this issue labels Mar 6, 2019
@flotwig
Copy link
Contributor

flotwig commented Mar 13, 2019 •
edited

Related issue: #3888

@flotwig flotwig self-assigned this Apr 3, 2019
@flotwig flotwig mentioned this issue Apr 3, 2019
Merged
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Apr 3, 2019
@flotwig flotwig added the process: build Related to our internal build process label Apr 5, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 8, 2019

The code for this is done in cypress-io/cypress#3877, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 17, 2019

Released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flotwig flotwig

Labels
OS: windows process: build Related to our internal build process type: chore Work is required w/ no deliverable to end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only package Windows builds of ffmpeg with Windows, build for win32 and win64 cypress-io/cypress
4 participants
@flotwig @brian-mann @jennifer-shehane @bahmutov