Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve focus UI and keyboard navigation in reporter #7855

Closed
panzarino opened this issue Jun 30, 2020 · 2 comments · Fixed by #7897
Closed

Improve focus UI and keyboard navigation in reporter #7855

panzarino opened this issue Jun 30, 2020 · 2 comments · Fixed by #7897
Assignees
Labels
type: enhancement Requested enhancement of existing feature type: user experience Improvements needed for UX

Comments

@panzarino
Copy link
Contributor

panzarino commented Jun 30, 2020

Current behavior:

Currently, the focus state when navigating and toggling the sidebar is fairly ugly and could be improved to be more similar to the hover state.

This is what it looks like now:
ezgif-6-03b3bf64ebbb

Keyboard controls:

Key Action
tab move down
shift + tab move up
enter open / close
space open / close

Similar behavior in other software:

Webstorm

ezgif-6-dcce8aaf609d

A click on the arrow will toggle open/closed, and a double click on the name or to the right of the name will open/close and shift focus.

Keyboard controls:

Key Action
down move down
up move up
left close
right open (move down if already open)
enter open / close

VS Code

ezgif-6-ea7d8b4fb9e8

A single click on the name (or anywhere on the line item) will open/close.

Keyboard controls:

Key Action
down move down
up move up
left close
right open (move down if already open)
space open / close
enter rename file

Atom

ezgif-6-4097b9c85f20

A single click on the name (or anywhere on the line item) will open/close.

Keyboard controls:

Key Action
down move down
up move up
left close
right open (move down if already open)
enter open / close

My Two Cents

We should remove the focus state when clicking and only leave it for keyboard navigation like we do with the print to console button. In addition, the focus state for keyboard navigation should be the same as the hover state, and not include an outline around the name. The keyboard controls are fairly standard for the browser and don't require a change, but I figured I would include them to provide a broader picture (perhaps we could also add additional keyboard shortcuts).

@panzarino panzarino added type: enhancement Requested enhancement of existing feature type: user experience Improvements needed for UX labels Jun 30, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress labels Jul 6, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 20, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 20, 2020

The code for this is done in cypress-io/cypress#7897, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 21, 2020

Released in 4.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.11.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Requested enhancement of existing feature type: user experience Improvements needed for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants