Mocking a route with an empty response body doesn't show the XHR call as being stubbed

[andreiduca]

Current behavior:

Mocking a route with an empty response body

cy.route('/sockjs-node/**', '').as('nodeSock');

incorrectly shows the XHR call not being stubbed:

Mocking the response body with a non-falsy value does produce the correct outcome:

cy.route('/sockjs-node/**', '1').as('nodeSock');

**Note: the request IS marked as stubbed in the Console in both cases:

Desired behavior:

Both examples should show the call as (xhr stub) in the test runner.

Test code to reproduce

1. Mock any route with an empty response body.
2. Observe the mocked XHR call note being shown as stubbed.

Versions

Cypress@4.10, node 12.16.3, macOS 10.15.5

[jennifer-shehane]

Yeah, I feel like this is solely a visual bug in the Test Runner's Command Log. This test passes, but it doesn't show up as xhr stub in the Command Log.

So, I don't this is actually affecting any behavior.

it('fails to show as stub in command log', () => {
  cy.visit('https://example.cypress.io/commands/aliasing')
  cy.server()
  cy.route('GET', 'comments/*', '').as('getComment')

  cy.get('.network-btn').click()
  cy.wait('@getComment').then((xhr) => {
    expect(xhr.response.body).to.eq('')
  })
})

Looks like a check here that is returning false when the response is ''. https://github.com/cypress-io/cypress/blob/develop/packages/driver/src/cy/commands/xhr.js#L44:L44

[jennifer-shehane]

Opened PR here: #8033

[cypress-bot]

The code for this is done in cypress-io/cypress#8033, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 4.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.11.0, please open a new issue.