-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: route all https traffic through proxy #8827
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@flotwig should we add tests for and tag as closed the issues this may fix related to cy.route2? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is quite a beautiful change. very very nice!!!
I'm not aware of any open issues that this fixes for cy.route2, we knew that there was an issue with breaking existing HTTPS connections but AFAIK no issues have been opened 🤷 |
Oh, actually, possibly #8815 is bein caused by this... |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
TR-416
pass all https through our proxy routes instead of making direct connections
User facing changelog
TBD
Additional details
How has the user experience changed?
PR Tasks
document.domain
) only affects aut domain