Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.should() should fail when only chainer getters supplied #883

Closed
dwelle opened this issue Nov 7, 2017 · 2 comments · Fixed by #8105
Closed

.should() should fail when only chainer getters supplied #883

dwelle opened this issue Nov 7, 2017 · 2 comments · Fixed by #8105
Labels
good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory type: bug

Comments

@dwelle
Copy link

dwelle commented Nov 7, 2017

Current behavior:

If user writes .should( chainer, value ) where chainer consists only of a chainer getter (e.g. to, be, is...), the command silently passes.

Desired behavior:

Instead, it should throw/fail because it's not a valid assertion. It's the same as if the user wrote expect( value ).be( value ) which is invalid chai assertion.

How to reproduce:

cy.wrap( 42 ).should('be', 100);
  • Cypress Version: 1.0.3
@jennifer-shehane jennifer-shehane added good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory stage: ready for work The issue is reproducible and in scope type: bug labels Nov 7, 2017
@flotwig
Copy link
Contributor

flotwig commented Jun 20, 2019

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 1, 2020

Released in 5.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.1.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: ready for work The issue is reproducible and in scope label Sep 1, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants