Skip to content

add viewport for macbook 16' #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sagarrajput opened this issue Oct 20, 2020 · 3 comments · Fixed by #8892
Closed

add viewport for macbook 16' #8889

sagarrajput opened this issue Oct 20, 2020 · 3 comments · Fixed by #8892

Comments

@sagarrajput
Copy link
Contributor

sagarrajput commented Oct 20, 2020

Current behavior

Currently, we don't have a preset of MacBook 16'

Desired behavior

Need to add a preset of MacBook 16' in our codebase.

Test code to reproduce

beforeEach(function () {
    cy.viewport('macbook-15')
    cy.login();
});

describe('Home page', () => {
    it('Home Page', () => {
        cy.navigateTo('Home');  
       
        cy.wait(2000);
    });
});

If you see in beforeEach for cy.viewport(''), we don;t have macbook-16' available.
Screenshot 2020-10-20 at 12 09 16 PM

Versions

Cypress: 5.4.0, MacOS 10.15.7 (19H2), Google Chrome:86.0.4240.80

@sagarrajput
Copy link
Contributor Author

I have opened PR with a fix for this issue, #8892
@jennifer-shehane This is my first PR in cypress, please let me know your thoughts.

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 20, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 21, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 21, 2020

The code for this is done in cypress-io/cypress#8892, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 27, 2020

Released in 5.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant