Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry proxied requests when network level errors occur #898

Closed
brian-mann opened this issue Nov 9, 2017 · 3 comments · Fixed by #4015
Closed

Retry proxied requests when network level errors occur #898

brian-mann opened this issue Nov 9, 2017 · 3 comments · Fixed by #4015
Labels
type: enhancement Requested enhancement of existing feature

Comments

@brian-mann
Copy link
Member

brian-mann commented Nov 9, 2017 •
edited

Need to implement the same kind of retry logic as this lib:

https://github.com/FGRibreau/node-request-retry

['ECONNRESET', 'ENOTFOUND', 'ESOCKETTIMEDOUT', 'ETIMEDOUT', 'ECONNREFUSED', 'EHOSTUNREACH', 'EPIPE', 'EAI_AGAIN']

TODO: research EPIPE we may not be able to retry from that.
@brian-mann brian-mann added the type: enhancement Requested enhancement of existing feature label Nov 9, 2017
@jennifer-shehane jennifer-shehane added the stage: ready for work The issue is reproducible and in scope label Nov 9, 2017
@brian-mann
Copy link
Member Author

cy.visit, cy.request, and transparently proxied requests should account for this.

IDEA: possibly expose this as global configuration to control the backoff algorithm? Even disable altogether?

retryProxiedRequests: true

@wijwoj wijwoj mentioned this issue Feb 9, 2018
Closed
@flotwig flotwig mentioned this issue May 1, 2019
Merged
5 tasks
@cypress-bot cypress-bot bot added stage: pending release and removed stage: ready for work The issue is reproducible and in scope labels May 15, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 15, 2019

The code for this is done in cypress-io/cypress#4015, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 17, 2019

Released in 3.3.0.

@jennifer-shehane jennifer-shehane mentioned this issue Jun 11, 2019
Closed
This was referenced Feb 4, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement Requested enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retry certain requests on failure cypress-io/cypress
2 participants
@brian-mann @jennifer-shehane