Merge foretagsplatsen fork into core #112

jaffrepaul · 2022-09-27T16:07:46Z

Merging maintained fork back into the core repo to be officially maintained internally.

For context, see this issue: #100

I will quickly switch to GitHub Actions.

NPM seems to be used everywhere else.

I don't want to support old versions of eslint. Let's stick to the 2 latest major releases for now.

@cypress

It seems @cypress's eslint global configuration is not up-to-date with eslint so I'm getting rid of it. Instead, I'm copy/pasting their rules in the .eslintrc.cjs file.

Bumps [globals](https://github.com/sindresorhus/globals) from 11.12.0 to 13.15.0. - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v11.12.0...v13.15.0) --- updated-dependencies: - dependency-name: globals dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…obals-13.15.0 chore(deps): bump globals from 11.12.0 to 13.15.0

Bumps [semantic-release](https://github.com/semantic-release/semantic-release) from 15.13.18 to 19.0.3. - [Release notes](https://github.com/semantic-release/semantic-release/releases) - [Commits](semantic-release/semantic-release@v15.13.18...v19.0.3) --- updated-dependencies: - dependency-name: semantic-release dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…mantic-release-19.0.3

Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) from 24.8.0 to 28.1.1. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v28.1.1/packages/jest) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…st-28.1.1

Fix package.json

…ded-config

chrisbreiding · 2022-09-29T15:27:32Z

.eslintrc.json

@@ -1,8 +0,0 @@
-{


Let's stick with this config so it's consistent with other cypress repos and will fit in better once this repo is moved to the monorepo.

chrisbreiding · 2022-09-29T15:28:28Z

.github/workflows/test.yml

@@ -0,0 +1,23 @@
+name: Test


Let's stick with Circle for CI tests, since it's already set up for it and will integrate better into the monorepo.

chrisbreiding · 2022-09-29T15:28:51Z

README.md

@@ -1,4 +1,4 @@
-# Cypress ESLint Plugin [![CircleCI](https://circleci.com/gh/cypress-io/eslint-plugin-cypress/tree/master.svg?style=svg)](https://circleci.com/gh/cypress-io/eslint-plugin-cypress/tree/master)
+# Cypress ESLint Plugin [![Test](https://github.com/cypress-io/eslint-plugin-cypress/actions/workflows/test.yml/badge.svg)](https://github.com/cypress-io/eslint-plugin-cypress/actions/workflows/test.yml)


This should stay pointing to Circle.

chrisbreiding · 2022-09-29T15:37:32Z

package.json

  "peerDependencies": {
-    "eslint": ">= 3.2.1"
+    "eslint": ">= 7.0.0"


This change makes this a breaking change, since users will have to upgrade their eslint to use it. To ensure this triggers a breaking change, it needs have a commit that follows the semantic release format, which is a bit different than triggering a patch or minor release.

DamienCassou · 2023-01-09T11:11:21Z

Any news about this?

jaffrepaul · 2023-01-09T17:05:50Z

@DamienCassou Yes! this is part of a much larger and multi-step change to the core Cypress repo. Some steps have been taken towards the ultimate goal of combining and simplifying linting and this plugin's behavior. Thanks for your patience and contribution!

Merged:

Still to come:

DamienCassou · 2023-08-16T08:38:11Z

Any news about this?

jaffrepaul · 2023-08-23T16:05:11Z

Thank you for following up contribution @DamienCassou!

Right now we don’t have the time available to put into reviewing and evaluating the changes proposed within the core Cypress repo but we'll keep this open for when more bandwidth is available.

CLAassistant · 2023-08-30T10:44:04Z

All committers have signed the CLA.

DamienCassou · 2023-11-15T19:36:12Z

@jennifer-shehane: is the work finished? Is the Cypress team giving up?

jennifer-shehane · 2023-11-16T16:29:34Z

@DamienCassou We don't have time to dedicate to this merge atm. Especially with it not being in a finished state.

DamienCassou and others added 30 commits June 27, 2022 13:14

Update package-lock.json

a62aaa7

Remove dependency toward CircleCI

6ce98ba

I will quickly switch to GitHub Actions.

Replace yarn with npm in a line of package.json

32b6e91

NPM seems to be used everywhere else.

Replace github.com/cypress-io with github.com/foretagsplatsen

2b7ddd7

Add .github/dependabot.yml

0ea3030

Get rid of husky (at least for now)

33eb0ea

Update eslint

93cfe75

I don't want to support old versions of eslint. Let's stick to the 2 latest major releases for now.

Replace eslint configuration

576f73e

It seems @cypress's eslint global configuration is not up-to-date with eslint so I'm getting rid of it. Instead, I'm copy/pasting their rules in the .eslintrc.cjs file.

Make code adhere to linting rules

d781c45

Add initial .ignore

b19b3dc

Add a GitHub action

5942f8c

Merge pull request #1 from foretagsplatsen/update-stack

e177d83

Add .editorconfig

ac2be75

Add npm script "make-rule" to ease creation of rules

54eb19f

Merge pull request #5 from foretagsplatsen/add-script-make-rule

c211fea

Merge pull request #2 from foretagsplatsen/dependabot/npm_and_yarn/gl…

6bb718f

…obals-13.15.0 chore(deps): bump globals from 11.12.0 to 13.15.0

Merge pull request #4 from foretagsplatsen/dependabot/npm_and_yarn/se…

7b340a0

…mantic-release-19.0.3

Add myself as CODEOWNERS

2e6bdb6

Merge pull request #6 from foretagsplatsen/make-myself-codeowner

dd730c9

Remove duplicated jest configuration

b794a14

Merge pull request #3 from foretagsplatsen/dependabot/npm_and_yarn/je…

58fe775

…st-28.1.1

Fix name of the package

3f3d391

Update version number in package.json

211e3f9

Add "publish" script

17ad353

Merge pull request #7 from foretagsplatsen/fix-package-json

7323d4d

Fix package.json

Add missing @finsit prefix in recommended config

93488cc

Merge pull request #8 from foretagsplatsen/fix-definition-of-recommen…

a4343bc

…ded-config

chrisbreiding requested changes Sep 29, 2022

View reviewed changes

jaffrepaul force-pushed the merge-foretagsplatsen-into-core branch 4 times, most recently from b53d775 to 0092ed9 Compare October 4, 2022 20:32

jaffrepaul added 2 commits October 4, 2022 16:46

revert to circle CI & remove GHA

5c93918

revert package.json values

6746e22

jaffrepaul force-pushed the merge-foretagsplatsen-into-core branch from 0092ed9 to 6746e22 Compare October 4, 2022 20:46

remove eslint v4 test in favor of adding v7

dcce8db

jaffrepaul force-pushed the merge-foretagsplatsen-into-core branch 2 times, most recently from 0ef177c to cd74e7f Compare October 4, 2022 21:04

bring back husky

5bd19fa

jaffrepaul force-pushed the merge-foretagsplatsen-into-core branch from cd74e7f to 5bd19fa Compare October 4, 2022 21:21

jaffrepaul added 3 commits October 4, 2022 17:21

set recommended rules back to base project

24f94ac

update contributors & note rule script

a8d9744

remove unnecessary packages in favor of reverting to core config

c680ef3

jaffrepaul force-pushed the merge-foretagsplatsen-into-core branch from 0a3acdd to c680ef3 Compare October 5, 2022 21:47

jaffrepaul marked this pull request as draft October 5, 2022 21:52

jaffrepaul added 3 commits October 12, 2022 14:30

revert eslint version & config to work with core

72301c7

install legacy-deps

6739c2e

fix lint errors

f2c7b41

jaffrepaul force-pushed the merge-foretagsplatsen-into-core branch from e632ad5 to f2c7b41 Compare October 12, 2022 18:30

jennifer-shehane closed this Nov 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge foretagsplatsen fork into core #112

Merge foretagsplatsen fork into core #112

jaffrepaul commented Sep 27, 2022 •

edited

chrisbreiding Sep 29, 2022

chrisbreiding Sep 29, 2022

chrisbreiding Sep 29, 2022

chrisbreiding Sep 29, 2022

DamienCassou commented Jan 9, 2023

jaffrepaul commented Jan 9, 2023

DamienCassou commented Aug 16, 2023

jaffrepaul commented Aug 23, 2023

CLAassistant commented Aug 30, 2023 •

edited

DamienCassou commented Nov 15, 2023

jennifer-shehane commented Nov 16, 2023

		@@ -1,4 +1,4 @@
		# Cypress ESLint Plugin [![CircleCI](https://circleci.com/gh/cypress-io/eslint-plugin-cypress/tree/master.svg?style=svg)](https://circleci.com/gh/cypress-io/eslint-plugin-cypress/tree/master)
		# Cypress ESLint Plugin [![Test](https://github.com/cypress-io/eslint-plugin-cypress/actions/workflows/test.yml/badge.svg)](https://github.com/cypress-io/eslint-plugin-cypress/actions/workflows/test.yml)

Merge foretagsplatsen fork into core #112

Merge foretagsplatsen fork into core #112

Conversation

jaffrepaul commented Sep 27, 2022 • edited

chrisbreiding Sep 29, 2022

Choose a reason for hiding this comment

chrisbreiding Sep 29, 2022

Choose a reason for hiding this comment

chrisbreiding Sep 29, 2022

Choose a reason for hiding this comment

chrisbreiding Sep 29, 2022

Choose a reason for hiding this comment

DamienCassou commented Jan 9, 2023

jaffrepaul commented Jan 9, 2023

DamienCassou commented Aug 16, 2023

jaffrepaul commented Aug 23, 2023

CLAassistant commented Aug 30, 2023 • edited

DamienCassou commented Nov 15, 2023

jennifer-shehane commented Nov 16, 2023

jaffrepaul commented Sep 27, 2022 •

edited

CLAassistant commented Aug 30, 2023 •

edited