Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use glob matching for consistency and update docs #139

Closed
wants to merge 10 commits into from

Conversation

passbyval
Copy link
Contributor

@passbyval passbyval commented Aug 9, 2023

Context

This is a followup for #137. I previously used a method to combine regexes, however, I realized this could produce a lot of unpredictable scenarios. It felt way too haphazard to me, so for simplicity and stability, I switched over to glob matching.

Summary

  • Switch to glob matching via micromatch
  • Split up unsafe-to-chain-command functions into individual files to be more SOLID, and so the tests/ folder doesn't become unruly in the future
  • Update docs to reflect the new methods option
  • Add more test cases

@cypress-app-bot
Copy link

@passbyval passbyval reopened this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants