fix: unsafe-to-chain-command: Fix the false positive of 'focus' regex matching 'focused'

[dominicfraser]

Addresses/ illustrates #140.

In #137 the unsafe-to-chain-command added a list of values to use as default unsafe commands.

Part of this list was

const unsafeToChainActions = [
  'blur',
  'clear',
  'click',
  'focus',
]

This is then used to create a regex

const isActionUnsafeToChain = (node, additionalMethods = []) => {
  const unsafeActionsRegex = new RegExp([
    ...unsafeToChainActions,
    ...additionalMethods.map((method) => method instanceof RegExp ? method.source : method),
  ].join('|'))

Using just the above this could be seen as

/blur|clear|click|focus/

However this regex is over zealous, it matches on focused as well as focus.

Focus is a safe command to chain. It is a query, not an action.

It is specified as safe in https://docs.cypress.io/api/commands/focused#Syntax.

This PR illustrates the problem, with a potential solution. If the implementation is reverted the test fails.

[CLAassistant]

All committers have signed the CLA.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[nagash77]

@dominicfraser good catch! Can you sign the CLA and I will get this merged in. Thanks for your PR!

[dominicfraser]

No problem!

[dqiubread]

@nagash77 any idea when a new release can be cut for this?

[MikeMcC399]

The release is tagged as https://github.com/cypress-io/eslint-plugin-cypress/releases/tag/v2.15.0 however the release failed as far as publishing to npm is concerned:

$ npm view eslint-plugin-cypress dist-tags
{ latest: '2.14.0' }

https://app.circleci.com/pipelines/github/cypress-io/eslint-plugin-cypress/170/workflows/e8b32fd1-8ac5-4395-908f-c42d60408a3c/jobs/674

[dqiubread]

The Circleci error looks like its an error with permissions

[MikeMcC399]

@dqiubread

The Circleci error looks like its an error with permissions

• You're right, however it has been fixed now, so that a release has gone through. See https://app.circleci.com/pipelines/github/cypress-io/eslint-plugin-cypress/175/workflows/75106844-5ec8-4598-9329-c3f33d2ca952/jobs/694 and
• fix: unsafe-to-chain-command: Fix the false positive of 'focus' regex matching 'focused' #144

[dqiubread]

@dqiubread

The Circleci error looks like its an error with permissions

• You're right, however it has been fixed now, so that a release has gone through. See https://app.circleci.com/pipelines/github/cypress-io/eslint-plugin-cypress/175/workflows/75106844-5ec8-4598-9329-c3f33d2ca952/jobs/694 and
• fix: unsafe-to-chain-command: Fix the false positive of 'focus' regex matching 'focused' #144

I see it now thanks.