Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add document for FlatCompat use #201

Merged
merged 1 commit into from May 6, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The README > Usage section describes how to add an .eslintrc.json configuration file to use the eslint-plugin-cypress plugin. With the announcement and release of ESLint v9 on Apr 5, 2024, configuration files in the format .eslintrc.* have become deprecated (see ESLint 8.x Configuration Files).

The plugin needs to document how to set up and use non-deprecated Configuration Files (New) for ESLint v8. These are JavaScript files using an eslint.config.*js naming convention. Users of the plugin may otherwise be blocked from preparing to update to ESLint v9 through lack of information.

Constraints

Plugins

Node.js

ESLint usage

Change

In order to provide clear, readable instructions for both legacy (.eslintrc.*) and new, flat config (eslint.config.*js) users, a separate document FLAT-CONFIG.md is created for the new flat config instructions.

Future steps

  • Building on this documentation change, include support for usage of the eslint-plugin-cypress plugin in FlatCompat compatibility mode together with ESLint v9 in addition to ESLint 8.57.0.

References

ESLint 8.x

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 self-assigned this May 5, 2024
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 5, 2024 16:46
@MikeMcC399

This comment was marked as outdated.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcC399 Thanks for adding this! It will help users be successful in the near term. Adding a lot of examples with the addition of other plugins is helpful.

@jennifer-shehane jennifer-shehane merged commit 730a260 into cypress-io:master May 6, 2024
8 checks passed
@MikeMcC399
Copy link
Collaborator Author

@jennifer-shehane

Thanks for adding this! It will help users be successful in the near term. Adding a lot of examples with the addition of other plugins is helpful.

The examples are complete tested and ready to copy-and-paste. So I hope these will be helpful to users. I would have been grateful to have them as I was trying to ramp up!

@cypress-app-bot
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants