Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rework contributor instructions #209

Merged
merged 1 commit into from May 9, 2024

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented May 9, 2024

Details

The CONTRIBUTING document is reworked and expanded in detail.

Corrections

  • The following step was added to the instructions. The fact that this was missing has led to rules being published inactive in the past. (See history of index.js listing multiple examples of this mistake over the years.)

    Add the rule to index.js

Additions

The following sections are added:

  • Preparation
  • Rule references
  • New rule
  • Document generation
  • Legacy tests

Generally the level of detail has been increased.

Document generation

The utility ESLint eslint-doc-generator is introduced as an optional way to produce consistent documentation. It has already been used in:

and so the README and documents in the docs/rules directory are prepared to use eslint-doc-generator.

Legacy tests

@cypress-app-bot
Copy link

@MikeMcC399
Copy link
Collaborator Author

@MikeMcC399 MikeMcC399 self-assigned this May 9, 2024
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 9, 2024 10:20
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Very straightforward

@jennifer-shehane jennifer-shehane merged commit 0fb820d into cypress-io:master May 9, 2024
6 checks passed
@MikeMcC399
Copy link
Collaborator Author

@jennifer-shehane

This is great! Very straightforward

Thanks! If there is any need for creating new rules, then rule authors should have a slightly easier time now!

@MikeMcC399 MikeMcC399 deleted the docs/contributor branch May 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants