BREAKING CHANGE to workflows due to Node.js upgrade 18 on Feb 13, 2023

[MikeMcC399]

Problem description

GitHub announced in https://github.com/actions/runner-images/issues/ that the default Node.js version will be changed to 18 starting on Feb 13, 2023.

This is a breaking change for two of the example workflows in .github/workflows due to the state of the underlying apps in the examples directory.

Workflows incompatible with default Node.js 18:

• .github/workflows/example-webpack.yml due to dependency on incompatible apps examples/webpack and examples/v9/webpack
• .github/workflows/example-wait-on.yml due to dependency on incompatible apps examples/react-scripts and examples/v9/react-scripts

Suggested fixes

• Merge PR Update v12 examples to 12.4.1 #747 to provide a new baseline of Cypress 12.4.1.

Then rebase the following PRs which upgrade the apps to work with Node.js 18:

• Update example webpack to run under Node.js 18 #708
• Update examples react-scripts for Node.js 18 #731

followed by a merge of these PRs.

Although cypress-io/github-action@v5 runs under node16, the apps run under the Node.js version in the workflow. If the version of Node.js is not set (for instance through actions/setup-node or a container parameter), then the app code runs under the default version of Node.js.

[MikeMcC399]

This issue is now resolved as the related PRs (see above) have been merged.

There should not be any problem caused by the planned GitHub update to use Node.js 18 as default starting on Feb 13, 2022.

[MikeMcC399]

There should not be any problem caused by the planned GitHub update to use Node.js 18 as default starting on Feb 13, 2022.

• I was a bit too optimistic! See example-wait-on fails on GitHub waiting for localhost #802