Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cypress-io/react-tooltip
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.0
Choose a base ref
...
head repository: cypress-io/react-tooltip
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.5.1
Choose a head ref
  • 19 commits
  • 7 files changed
  • 5 contributors

Commits on Jun 20, 2019

  1. chore: add renovate

    bahmutov committed Jun 20, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    ijjk JJ Kasper
    Copy the full SHA
    2c1309f View commit details

Commits on Jun 21, 2019

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    7895454 View commit details
  2. chore(deps): pin dependencies (#6)

    chore(deps): pin dependencies
    
    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    jennifer-shehane and renovate-bot authored Jun 21, 2019
    Copy the full SHA
    3b8f9d3 View commit details

Commits on Jun 22, 2019

  1. Copy the full SHA
    f440a81 View commit details

Commits on Jun 23, 2019

  1. Copy the full SHA
    f2570d0 View commit details

Commits on Jun 24, 2019

  1. chore(deps): update dependency eslint to v6 (#8)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    2 people authored and jennifer-shehane committed Jun 24, 2019
    Copy the full SHA
    2ac6d76 View commit details

Commits on Jun 28, 2019

  1. chore(deps): update dependency eslint-plugin-cypress-dev to v3 (#9)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    2 people authored and jennifer-shehane committed Jun 28, 2019
    Copy the full SHA
    a048ebc View commit details
  2. chore(deps): update dependency semantic-release to v15.13.18 (#12)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    2 people authored and jennifer-shehane committed Jun 28, 2019
    Copy the full SHA
    5777fe1 View commit details

Commits on Jun 29, 2019

  1. Copy the full SHA
    9268794 View commit details
  2. Copy the full SHA
    6c1851d View commit details
  3. Copy the full SHA
    65faa83 View commit details

Commits on Jul 6, 2019

  1. Copy the full SHA
    6c7db04 View commit details

Commits on Jul 10, 2019

  1. Copy the full SHA
    f06c643 View commit details

Commits on Jul 13, 2019

  1. Copy the full SHA
    f08b5c6 View commit details

Commits on Jul 20, 2019

  1. Copy the full SHA
    ae1d997 View commit details

Commits on Jul 21, 2019

  1. Copy the full SHA
    f58d7fa View commit details

Commits on Jul 23, 2019

  1. chore(deps): update dependency eslint-plugin-mocha to v6 (#22)

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    2 people authored and jennifer-shehane committed Jul 23, 2019
    Copy the full SHA
    f7e0b82 View commit details

Commits on Jul 27, 2019

  1. Copy the full SHA
    552f71c View commit details

Commits on Jul 29, 2019

  1. Copy the full SHA
    8c47648 View commit details
Showing with 251 additions and 187 deletions.
  1. +4 −1 README.md
  2. +200 −170 package-lock.json
  3. +15 −15 package.json
  4. +16 −0 renovate.json
  5. +1 −0 src/portal-popper.spec.jsx
  6. +5 −1 src/portal.jsx
  7. +10 −0 src/portal.spec.jsx
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# React Tooltip [![CircleCI](https://circleci.com/gh/cypress-io/react-tooltip.svg?style=svg)](https://circleci.com/gh/cypress-io/react-tooltip)
# React Tooltip [![renovate-app badge][renovate-badge]][renovate-app] [![CircleCI](https://circleci.com/gh/cypress-io/react-tooltip.svg?style=svg)](https://circleci.com/gh/cypress-io/react-tooltip)

A tooltip component for React apps utilizing the excellent [popper.js library](https://popper.js.org).

@@ -63,3 +63,6 @@ For latest changelog see [cypress-io/react-tooltip/releases](https://github.com/

#### 0.1.0 - *(09/28/16)*
- Initial release

[renovate-badge]: https://img.shields.io/badge/renovate-app-blue.svg
[renovate-app]: https://renovateapp.com/
370 changes: 200 additions & 170 deletions package-lock.json

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions package.json
Original file line number Diff line number Diff line change
@@ -29,26 +29,26 @@
"popper.js": "^1.15.0"
},
"devDependencies": {
"babel-eslint": "^10.0.2",
"chai": "^4.2.0",
"babel-eslint": "10.0.2",
"chai": "4.2.0",
"chai-enzyme": "1.0.0-beta.1",
"condition-circle": "2.0.2",
"dont-crack": "1.2.1",
"enzyme": "3.10.0",
"enzyme-adapter-react-16": "1.14.0",
"eslint": "^5.16.0",
"eslint-plugin-cypress-dev": "^2.1.0",
"eslint-plugin-mocha": "^5.3.0",
"eslint-plugin-react": "^7.13.0",
"fs-extra": "8.0.1",
"jsdom": "^9.5.0",
"lodash": "^4.17.11",
"prop-types": "^15.7.2",
"react": "16.5.2",
"react-dom": "16.5.2",
"semantic-release": "^15.13.16",
"sinon": "^7.3.2",
"sinon-chai": "^3.3.0",
"eslint": "6.1.0",
"eslint-plugin-cypress-dev": "3.0.2",
"eslint-plugin-mocha": "6.0.0",
"eslint-plugin-react": "7.14.3",
"fs-extra": "8.1.0",
"jsdom": "9.12.0",
"lodash": "4.17.15",
"prop-types": "15.7.2",
"react": "16.8.6",
"react-dom": "16.8.6",
"semantic-release": "15.13.18",
"sinon": "7.3.2",
"sinon-chai": "3.3.0",
"zunder": "6.4.1"
},
"peerDependencies": {
16 changes: 16 additions & 0 deletions renovate.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"extends": [
"config:base"
],
"automerge": true,
"major": {
"automerge": false
},
"prHourlyLimit": 2,
"updateNotScheduled": false,
"timezone": "America/New_York",
"schedule": [
"every weekend"
],
"masterIssue": true
}
1 change: 1 addition & 0 deletions src/portal-popper.spec.jsx
Original file line number Diff line number Diff line change
@@ -84,6 +84,7 @@ describe('<PortalPopper />', () => {
expect(Popper.firstCall.args[2].modifiers.preventOverflow).to.eql({
boundariesElement: 'boundary',
})

expect(Popper.firstCall.args[2].onCreate).to.be.a('function')
expect(Popper.firstCall.args[2].onUpdate).to.be.a('function')
})
6 changes: 5 additions & 1 deletion src/portal.jsx
Original file line number Diff line number Diff line change
@@ -25,7 +25,11 @@ class Portal extends Component {
componentWillUnmount () {
const appendTo = this.props.appendTo

appendTo.removeChild(this._element)
// it's possible the element was removed from the dom or the dom has been
// blown away, which will cause `removeChild` to throw an exception
try {
appendTo.removeChild(this._element)
} catch (err) {} // eslint-disable-line no-empty
}

render () {
10 changes: 10 additions & 0 deletions src/portal.spec.jsx
Original file line number Diff line number Diff line change
@@ -28,4 +28,14 @@ describe('<Portal />', () => {
component.unmount()
expect(document.getElementById('portal-0')).not.to.exist
})

it('gracefully handles the portal div no longer existing on unmount', () => {
Portal.idNum = 0
const component = mount(<Portal />)

document.getElementById('portal-0').remove()

component.unmount() // should not error
expect(document.getElementById('portal-0')).not.to.exist
})
})