Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

pysam build fails on python3.8 #86

Open
lincoln-harris opened this issue Jul 15, 2020 · 5 comments · Fixed by #87
Open

pysam build fails on python3.8 #86

lincoln-harris opened this issue Jul 15, 2020 · 5 comments · Fixed by #87

Comments

@lincoln-harris
Copy link
Collaborator

lincoln-harris commented Jul 15, 2020

this is a known issue: jbloomlab/alignparse#58

one way to get around it is perhaps a conda installation of pysam?

@lincoln-harris lincoln-harris changed the title pysam fails on python3.8 pysam build fails on python3.8 Jul 15, 2020
@lincoln-harris
Copy link
Collaborator Author

lincoln-harris commented Jul 15, 2020

or possibly remove the pysam dependency entirely? its not clear that its being used...could just be vestigal at this point

i've been testing this on #87 -- as far as i can tell all tests pass when pysam is removed from requirements.txt

@lincoln-harris lincoln-harris linked a pull request Jul 15, 2020 that will close this issue
3 tasks
@lincoln-harris
Copy link
Collaborator Author

@rvanheusden any ideas on what pysam was doing?

@rvanheusden
Copy link
Contributor

I don't know if pysam was ever an actual requirement. It was added in 1e7ea1e along with Biopython, but I don't think it's needed.

@lincoln-harris
Copy link
Collaborator Author

beautiful, thank you

@lincoln-harris
Copy link
Collaborator Author

reopening this, ref #83.

pysam has been removed from requirements.txt and this seems to be working for now, on python 3.6, 3.7, 3.8.
we still very much depend on pysam however.

anticipating this being an issue again in the future, will keep open.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants