Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate (syntax + type check) queries #16

Open
d12 opened this issue Jun 22, 2018 · 0 comments
Open

Validate (syntax + type check) queries #16

d12 opened this issue Jun 22, 2018 · 0 comments

Comments

@d12
Copy link
Owner

d12 commented Jun 22, 2018

Presently, if one field tries to load a syntactically invalid or type-invalid query, it will break the entire batched query and no data will be loaded.

This could be avoided by validating queries before the merging step.

This will incur a performance hit though, and it'll require users to provide a schema definition for the APIs their dependent on. A good mid-way point might just be syntactically validating queries, and ignoring type-correctness. This way, we don't need an SDL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant