.del(key, options, cb) method not returning a Promise

[markoivanovski]

node-cache-manager-ioredis/index.js

Line 69 in 3bf4514

self.del = (key, options, cb) => {

The delete method does not appear to be wrapped in a Promise, giving it a different signature to the other methods. Believe it is supposed to?

self.del = (key, options, cb) => {
  if (typeof options === 'function') {
    cb = options;
  }

  redisCache.del(key, handleResponse(cb));
};

[markoivanovski]

@dabroek I have linked a PR that fixes the issue, do you think it could be merged and release?

Thanks!

[ehaynes99]

Was the PR just closed due to inactivity? This has been inconsistent with the cache-manager#Cache interface all along, and the fix simply follows the pattern of the others...

[Tirke]

@markoivanovski Did a rewrite of this package with del returning a promise here: https://www.npmjs.com/package/@tirke/node-cache-manager-ioredis