Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ioredis 5 #32

Open
phoenix741 opened this issue Jul 4, 2022 · 4 comments
Open

Upgrade to ioredis 5 #32

phoenix741 opened this issue Jul 4, 2022 · 4 comments

Comments

@phoenix741
Copy link

Hi,

Can you upgrade to ioredis 5.* ?

Thanks

@kenzik
Copy link

kenzik commented Jul 30, 2022

Can you describe what issues you have encountered using this package out of the box and/or why specifically you are looking for support for ioredis 5.* ?

From what I understand this just uses get/set, so I'm curious as to your situation.

@phoenix741
Copy link
Author

In our project team we have the policy to update libraries (and nodejs) to latest version to ensure to be always up to date, have all corrections, and vulnerabilities fixes.

More, in a project that depends of ioredis and "node-cache-manager-ioredis" having two version of ioredis increase the bundle by having two version of a library server side (ie: when using lambda).

ioredis 4.* is already 6 months old.

We don't encounter issue at today.

@Tirke
Copy link

Tirke commented Aug 9, 2022

Hi @phoenix741 Did a rewrite of this package with ioredis@latest here: https://www.npmjs.com/package/@tirke/node-cache-manager-ioredis

@schmod
Copy link

schmod commented Oct 4, 2022

personally, I'd just remove the direct dependency on ioredis and make the External Redis Instance configuration pattern mandatory.

It makes dependency-management far simpler, and at worse, only adds about 2 extra lines of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants