Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to OpenTelemetry #735

Closed
Alvise88 opened this issue Jun 27, 2021 · 3 comments · Fixed by #778
Closed

Move to OpenTelemetry #735

Alvise88 opened this issue Jun 27, 2021 · 3 comments · Fixed by #778

Comments

@Alvise88
Copy link
Contributor

Dagger use OpenTracing to export traces, OpenTelemetry is considered the new version of both OpenTracing and OpenCensus

Getting started
Migration guide
Example

@aluzzardi
Copy link
Member

Thanks @Alvise88!

We originally used OpenTracing because that's what BuildKit uses, but they actually added support for OpenTelemetry just 2 weeks ago so we can migrate now :)

moby/buildkit#2152

I'll add this to our roadmap. Would you be interested in contributing this change?

@Alvise88
Copy link
Contributor Author

Alvise88 commented Jul 1, 2021

Thanks @Alvise88!

We originally used OpenTracing because that's what BuildKit uses, but they actually added support for OpenTelemetry just 2 weeks ago so we can migrate now :)

moby/buildkit#2152

I'll add this to our roadmap. Would you be interested in contributing this change?

Ok, i will do it in the next few days

@Alvise88
Copy link
Contributor Author

Alvise88 commented Jul 2, 2021

I created a new branch fo this issue: https://github.com/Alvise88/dagger/tree/move-to-opentelemetry

Instead of JAEGER_TRACE you have to use OTEL_EXPORTER_JAEGER_ENDPOINT, it can be:

  1. http://host.docker.internal:14268/api/traces (at least docker 20)
  2. http://localhost:14268/api/traces

What do you think ? Do you have any suggestions to improve what I have done ? @aluzzardi

The pull request is failed due to buildkit mismatch (there is no buildkit tagged with opentelemetry, but only master)

@aluzzardi aluzzardi linked a pull request Jul 8, 2021 that will close this issue
aluzzardi added a commit that referenced this issue Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants