expose "subscribe" function for "createGlobalState" #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the suggestion. subscribe('count', (count) => {
console.log(`count ${count}`);
});Does it solve your use case? |
|
Yes, it would be good. |
|
Cool. Could you update the PR for it? |
|
Done. |
dai-shi
reviewed
Dec 4, 2022
| @@ -105,6 +105,7 @@ It returns a set of functions | |||
| * `useGlobalState`: a custom hook works like React.useState | |||
| * `getGlobalState`: a function to get a global state by key outside React | |||
| * `setGlobalState`: a function to set a global state by key outside React | |||
| * `subscribe`: a function that subscribes to state changes | |||
There was a problem hiding this comment.
The api doc is generated from the source code. Can you edit jsdoc in code and run yarn run apidoc?
|
Published: https://www.npmjs.com/package/react-hooks-global-state/v/2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
subscribefunction would be very helpful, because I often need to persist some parts of global state in local storage, and there is no easy and clean way to do this. Best I could do is to create an effects-only component that listens global state by hooks, which works but is verbose and feels complicated.