Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension startup time is so long #53

Closed
tjx666 opened this issue Jun 29, 2021 · 8 comments · Fixed by #64
Closed

extension startup time is so long #53

tjx666 opened this issue Jun 29, 2021 · 8 comments · Fixed by #64
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tjx666
Copy link
Contributor

tjx666 commented Jun 29, 2021

I think there should not be so much log after publish the extension. The startup time costs so long may be also related to this?

image
@daidodo
Copy link
Owner

daidodo commented Jul 1, 2021

Thanks for the feedback!

Unfortunately I don't have much time recently. So if you or someone could help with the issue, I'd be very grateful!

@daidodo daidodo added the help wanted Extra attention is needed label Jul 1, 2021
@tjx666
Copy link
Contributor Author

tjx666 commented Jul 2, 2021

If I have time, I may help to fix it.

@daidodo daidodo added the enhancement New feature or request label Oct 30, 2021
@tjx666
Copy link
Contributor Author

tjx666 commented Jan 6, 2022 •
edited by daidodo

@daidodo

module format-imports import costs too long,

image

@daidodo
Copy link
Owner

daidodo commented Jan 6, 2022

Thanks for the sharing!

This reminds me a previous attempt to webpack the plugin which failed due to eslint loading issues: eslint/eslint#13974.

Currently, I'm on something else but happy to suggest if you're interested.

@tjx666 tjx666 mentioned this issue Mar 6, 2022
Merged
@tjx666
Copy link
Contributor Author

tjx666 commented Mar 6, 2022

@daidodo fixed in #64

@daidodo daidodo linked a pull request Mar 6, 2022 that will close this issue
optimize startup speed #53 #64
Merged
daidodo added a commit that referenced this issue Mar 14, 2022
@daidodo
Merge pull request #64 from tjx666/master
e61cc63 
optimize startup speed  #53
@daidodo daidodo reopened this Mar 14, 2022
@daidodo
Copy link
Owner

daidodo commented Mar 31, 2022

@tjx666
Sorry for the late response!
I believe there is an improvement from the new release v7.4.13 after I webpacked the extension.

image

It was quite a journey to make a solution from:

Please have a try and tell me if you have any questions.
Thanks!

@tjx666
Copy link
Contributor Author

tjx666 commented Apr 2, 2022 •
edited

image

@tjx666
Copy link
Contributor Author

tjx666 commented Apr 2, 2022

Much better than before @daidodo

@tjx666 tjx666 closed this as completed Apr 2, 2022
@daidodo daidodo mentioned this issue Apr 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

optimize startup speed #53 tjx666/format-imports-vscode
2 participants
@daidodo @tjx666