From d2834fb97f017571f39582aa8b9c439fe73ded9a Mon Sep 17 00:00:00 2001
From: Nitzan Uziely <linkgoron@gmail.com>
Date: Fri, 5 Mar 2021 14:37:57 +0200
Subject: [PATCH] fs: improve fsPromises writeFile performance

Increase the write chunk size in fsPromises writeFile
to improve performance.

PR-URL: https://github.com/nodejs/node/pull/37610
Backport-PR-URL: https://github.com/nodejs/node/pull/39993
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
 lib/internal/fs/promises.js                    |  3 +--
 lib/internal/fs/utils.js                       |  3 +++
 .../test-fs-promises-file-handle-writeFile.js  | 18 +++++++++++-------
 3 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
index 9487f48e841dbd..be8d35e13e97e4 100644
--- a/lib/internal/fs/promises.js
+++ b/lib/internal/fs/promises.js
@@ -1,7 +1,5 @@
 'use strict';
 
-const kWriteFileMaxChunkSize = 2 ** 14;
-
 const {
   ArrayPrototypePush,
   Error,
@@ -40,6 +38,7 @@ const {
     kMaxUserId,
     kReadFileBufferLength,
     kReadFileUnknownBufferLength,
+    kWriteFileMaxChunkSize,
   },
   copyObject,
   getDirents,
diff --git a/lib/internal/fs/utils.js b/lib/internal/fs/utils.js
index 1d4edc0e011e4c..6af79033f452b6 100644
--- a/lib/internal/fs/utils.js
+++ b/lib/internal/fs/utils.js
@@ -126,6 +126,8 @@ const kIoMaxLength = 2 ** 31 - 1;
 const kReadFileUnknownBufferLength = 64 * 1024;
 const kReadFileBufferLength = 512 * 1024;
 
+const kWriteFileMaxChunkSize = 512 * 1024;
+
 const kMaxUserId = 2 ** 32 - 1;
 
 const isWindows = process.platform === 'win32';
@@ -835,6 +837,7 @@ module.exports = {
     kMaxUserId,
     kReadFileBufferLength,
     kReadFileUnknownBufferLength,
+    kWriteFileMaxChunkSize,
   },
   assertEncoding,
   BigIntStats,  // for testing
diff --git a/test/parallel/test-fs-promises-file-handle-writeFile.js b/test/parallel/test-fs-promises-file-handle-writeFile.js
index 46c9019bc8d8dd..6458144657dae9 100644
--- a/test/parallel/test-fs-promises-file-handle-writeFile.js
+++ b/test/parallel/test-fs-promises-file-handle-writeFile.js
@@ -34,13 +34,17 @@ async function validateWriteFile() {
 async function doWriteAndCancel() {
   const filePathForHandle = path.resolve(tmpDir, 'dogs-running.txt');
   const fileHandle = await open(filePathForHandle, 'w+');
-  const buffer = Buffer.from('dogs running'.repeat(10000), 'utf8');
-  const controller = new AbortController();
-  const { signal } = controller;
-  process.nextTick(() => controller.abort());
-  await assert.rejects(writeFile(fileHandle, buffer, { signal }), {
-    name: 'AbortError'
-  });
+  try {
+    const buffer = Buffer.from('dogs running'.repeat(512 * 1024), 'utf8');
+    const controller = new AbortController();
+    const { signal } = controller;
+    process.nextTick(() => controller.abort());
+    await assert.rejects(writeFile(fileHandle, buffer, { signal }), {
+      name: 'AbortError'
+    });
+  } finally {
+    await fileHandle.close();
+  }
 }
 
 const dest = path.resolve(tmpDir, 'tmp.txt');