Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRF 3.15.0 is incompatible #1896

Open
mvandenburgh opened this issue Mar 19, 2024 · 1 comment
Open

DRF 3.15.0 is incompatible #1896

mvandenburgh opened this issue Mar 19, 2024 · 1 comment

Comments

@mvandenburgh
Copy link
Contributor

mvandenburgh commented Mar 19, 2024 •
edited

Example failing test run using DRF 3.15.0 - https://github.com/dandi/dandi-archive/actions/runs/8283015197/job/22853304575

Error message:

django.core.exceptions.ImproperlyConfigured: Router with basename "asset" is already registered. Please provide a unique basename for viewset "<class 'dandiapi.api.views.asset.AssetViewSet'>"

We should read through the release notes and DRF issues to see what we need to change to use the latest DRF release.

(Original issue mentioning test failures - #1894)
@mvandenburgh mvandenburgh changed the title DRF 3.15.0 breaks tests DRF 3.15.0 is incompatible Mar 19, 2024
@waxlamp
Copy link
Member

waxlamp commented Mar 20, 2024

Might be this PR (which was folded into the latest release): encode/django-rest-framework#8438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waxlamp @mvandenburgh