Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dandiset pagination appears broken. #1917

Closed
satra opened this issue Apr 4, 2024 · 5 comments · Fixed by #1947
Closed

dandiset pagination appears broken. #1917

satra opened this issue Apr 4, 2024 · 5 comments · Fixed by #1947
Assignees
Labels
bug Something isn't working released This issue/pull request has been released. UX Affects usability of the system

Comments

@satra
Copy link
Member

satra commented Apr 4, 2024

to replicate:

  1. go to main dandi
  2. click on public dandisets
  3. now click on any page number at the bottom. (it will take you to a page that only shows one page).

it take you to that page (presumably) but one cannot go to either the previous page or the next page in sequence.

@satra satra added the bug Something isn't working label Apr 4, 2024
@jjnesbitt
Copy link
Member

This is due to #1911. We thought there was nothing else that relied on the count field being present on every page, but we missed the call to dandisets from the web client. Our options are to either re-enable that pagination scheme just for the dandisets endpoint, or to only show the current page you're on, with previous / next buttons.

@satra
Copy link
Member Author

satra commented Apr 5, 2024

@jjnesbitt - previous next buttons sound good to me. will we able to share a link/view to a given page (using url parameters)?

ps. those components in the UI will be one of the priorities to redo in the coming year given scale and diversity of dandisets coming online (and moving more to a faceted/ai bot search style).

@satra
Copy link
Member Author

satra commented Apr 5, 2024

although this is another case of losing a feature with no test though. (cc:ing @waxlamp since he asks for use-cases of ui tests).

@satra
Copy link
Member Author

satra commented May 14, 2024

@waxlamp @jjnesbitt - bumping this - i thought this was just a pagination bug on dandisets. looks like it's also happening with the File browser. hence something more general broke.

@dandibot
Copy link
Member

dandibot commented Jun 3, 2024

🚀 Issue was released in v0.3.85 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released This issue/pull request has been released. UX Affects usability of the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants