You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@yarikoptic In commit 035e64e, you removed the invocation of matlab -nodesktop -sd $INSTALL_DIR -batch 'generateCore()' from MatNWBInstaller.install(). As a result, the only thing the install() method now does is call download() and then run git clean -dxf on the downloaded clone of the MatNWB repository.
Should the call to git clean -dxf be kept?
Should git clean -dxf be run every time the download() method is called?
The text was updated successfully, but these errors were encountered:
frankly -- I don't know if there are any side effects or why we even originally called that git clean -dxf... it was added by you in e5261ef and before the generateCore . Do you recall the reason/need for it? if not -- we could test on some passed/failing file and deduce why it was needed , or just keep as historical artifact - I guess it doesn't hurt and should not take long
@yarikoptic I think it was added in order to delete any artifacts produced by a previous call to generateCore(), thereby ensuring a clean core-generation. Now that we don't call generateCore() explicitly, it is called implicitly when MatNWB is loaded?
@yarikoptic In commit 035e64e, you removed the invocation of
matlab -nodesktop -sd $INSTALL_DIR -batch 'generateCore()'
fromMatNWBInstaller.install()
. As a result, the only thing theinstall()
method now does is calldownload()
and then rungit clean -dxf
on the downloaded clone of the MatNWB repository.git clean -dxf
be kept?git clean -dxf
be run every time thedownload()
method is called?The text was updated successfully, but these errors were encountered: