Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatNWB installation steps still needed? #65

Open
jwodder opened this issue Jan 17, 2024 · 3 comments
Open

MatNWB installation steps still needed? #65

jwodder opened this issue Jan 17, 2024 · 3 comments

Comments

@jwodder
Copy link
Member

jwodder commented Jan 17, 2024

@yarikoptic In commit 035e64e, you removed the invocation of matlab -nodesktop -sd $INSTALL_DIR -batch 'generateCore()' from MatNWBInstaller.install(). As a result, the only thing the install() method now does is call download() and then run git clean -dxf on the downloaded clone of the MatNWB repository.

  • Should the call to git clean -dxf be kept?
  • Should git clean -dxf be run every time the download() method is called?
@yarikoptic
Copy link
Member

frankly -- I don't know if there are any side effects or why we even originally called that git clean -dxf... it was added by you in e5261ef and before the generateCore . Do you recall the reason/need for it? if not -- we could test on some passed/failing file and deduce why it was needed , or just keep as historical artifact - I guess it doesn't hurt and should not take long

@jwodder
Copy link
Member Author

jwodder commented Jan 17, 2024

@yarikoptic I think it was added in order to delete any artifacts produced by a previous call to generateCore(), thereby ensuring a clean core-generation. Now that we don't call generateCore() explicitly, it is called implicitly when MatNWB is loaded?

@yarikoptic
Copy link
Member

Frankly - I don't know without trying, and behavior might change. Might be safest to just leave cleaning in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants