Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: danger/danger-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.7.1
Choose a base ref
...
head repository: danger/danger-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.7.2
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on May 19, 2018

  1. Better Peril debugging

    orta committed May 19, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    344af5e View commit details
  2. Prepare for release

    orta committed May 19, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    941f0a7 View commit details
Showing with 10 additions and 8 deletions.
  1. +1 −1 .vscode/settings.json
  2. +4 −0 CHANGELOG.md
  3. +0 −4 dangerfile.ts
  4. +1 −1 package.json
  5. +4 −2 source/platforms/github/GitHubAPI.ts
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -23,5 +23,5 @@
"spellchecker.ignoreFileExtensions": [],
"spellchecker.checkInterval": 5000,
"editor.formatOnSave": true,
"cSpell.words": ["PRDSL", "bitbucket"]
"cSpell.words": ["APIPR", "Commenter", "PRDSL", "bitbucket"]
}
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -13,6 +13,10 @@

## Master

# 3.7.2

* Debugging when using the GitHub OctoKit - orta

# 3.7.1

* Improve checks support for Danger - orta
4 changes: 0 additions & 4 deletions dangerfile.ts
Original file line number Diff line number Diff line change
@@ -34,10 +34,6 @@ const checkREADME = async () => {
}
checkREADME()

warn("a warning", "dangerfile.ts", 3)

warn("another warning", "source/runner/runners/vm2.ts", 3)

import yarn, { message } from "danger-plugin-yarn"
yarn()

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "danger",
"version": "3.7.1",
"version": "3.7.2",
"description": "Unit tests for Team Culture",
"main": "distribution/danger.js",
"typings": "distribution/danger.d.ts",
6 changes: 4 additions & 2 deletions source/platforms/github/GitHubAPI.ts
Original file line number Diff line number Diff line change
@@ -44,12 +44,14 @@ export class GitHubAPI {
*/
getExternalAPI = (JWTForGithubApp?: string): GitHubNodeAPI => {
const host = process.env["DANGER_GITHUB_API_BASE_URL"] || undefined
const api = new GitHubNodeAPI({
const options: GitHubNodeAPI.Options & { debug: boolean } = {
debug: !!process.env.LOG_FETCH_REQUESTS,
baseUrl: host,
headers: {
...this.additionalHeaders,
},
})
}
const api = new GitHubNodeAPI(options)

if (JWTForGithubApp) {
// I sent a PR for this: https://github.com/octokit/rest.js/pull/873