Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] src/something/tests.tsx doesnt get looked at #120

Open
pvinis opened this issue Sep 29, 2023 · 2 comments
Open

[BUG] src/something/tests.tsx doesnt get looked at #120

pvinis opened this issue Sep 29, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@pvinis
Copy link

pvinis commented Sep 29, 2023

Describe the bug
We have files like src/something/tests.tsx and the rules of this repo don't run there!

Expected behavior
The rules should run on there too.

Additional context
I noticed that on https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/src/index.ts#L141-L151 there is a list of filenames, and ours is not in there. I could make a PR to add these, but also I think we can probably remove the overrides bit from this file, and put the rules one level up, as a sibling to plugins, and everything will work well.

Normally (and we too) people have a testMatch on the jest config, so it already knows all the test files of the project. No need to have special detection on this repo.

Let me know if I should make a PR to add our test or if I should make a PR removing the overrides.

@pvinis pvinis added the bug Something isn't working label Sep 29, 2023
@benkimpel
Copy link
Collaborator

Sorry for the late reply. Go for it!

@benkimpel
Copy link
Collaborator

Although, now that I think about it... @pvinis, I believe you should be able to override these file patterns from the plugin in your own setup. IIRC this was just something we did as a convenience and as a way to make sure that the plugin doesn't run against source files out of the box.

However, it's been a while since I've worked in this ecosystem at this point, so I will defer to @dangreenisrael, @hockeybuggy, or any of the other collaborators on this project. (I should probably remove myself from the project.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants