Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

className is missing on typescript props type #41

Open
piedrahitapablo opened this issue May 18, 2021 · 3 comments
Open

className is missing on typescript props type #41

piedrahitapablo opened this issue May 18, 2021 · 3 comments

Comments

@piedrahitapablo
Copy link

piedrahitapablo commented May 18, 2021

Hi, thanks for your work on this package. I found a bug in the type stubs

Here you can see that the component allows passing className on its props, but that's not reflected on the type stubs. Also, that prop is missing on the repo README.

I can make a PR later this week if that's ok.

@daniel-lundin
Copy link
Owner

Hi,

Yes, that would be appreciated!

@HartiganHM
Copy link

Hey, @daniel-lundin! It looks like there's a fix for this in #35. Any chance it could get reviewed/merged in? Happy to help, if possible!

@dannydi12
Copy link

@daniel-lundin - seems like there no movement on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants