not working

[csrgxtu]

[danieldelcore]

Hi there, are you using Hyper 2.0?
If so, this plugin wont work because the underlying terminal emulator has changed (to xterm). I'll need to refactor in order support the new xterm api.

[ljstella]

@danieldelcore Is the plain to deprecate this entirely? iTerm triggers are super useful for on-the-fly syntax highlighting, really helpful when connected to a firewall or switch and looking through the config, or when writing more configs. I haven't found another project that emulates iTerm triggers.

[danieldelcore]

Hi @ljstella, I'm really happy to see that you want to use this!
Unfortunately the new terminal emulator, xTerm, introduced in v2.0.0 has a drastically different api. We're no longer able to inspect the terminal output and render triggers because everything is now rendered to a canvas.

It does, however, have basic support for file paths but no options for customisation... 😭

If you find a way to get around this i would love to hear about it or review your pull requests.

[danieldelcore]

We could hook into this api to customise the link matcher: https://xtermjs.org/docs/api/terminal/interfaces/ilinkmatcheroptions/

[danieldelcore]

FYI, i did some tinkering over the weekend and managed to refactor the plugin to work on v2. I'm going to do some polishing and do a major version bump.

CC @ljstella @csrgxtu

[danieldelcore]

Gladly, i can remove the deprecation 🎉

[Wizek]

Wonderful! I'm looking forward to a version that works with v2! I would really like to be able to click a link like /path/to/file.js:123 and have it open in my $EDITOR at the exact relevant line. Any way I could make that work even today? Or is there some work still left before that is possible? Or perhaps I should downgrade to v1 in the meantime?

Also, relevant issue: vercel/hyper#413