Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to achieve a better process rollback workflow #1246

Open
codecodecookie opened this issue Mar 7, 2024 · 4 comments
Open

How to achieve a better process rollback workflow #1246

codecodecookie opened this issue Mar 7, 2024 · 4 comments

Comments

@codecodecookie
Copy link

I use json define workflow like the following picture:

image

but when the steps nodes become more and more,the decision branch may not be a good solution.I have tyied with this funciton:
At the StepType corresponding method in Run(),use
return ExecutionResult.Branch(new List { context.Item }, "A_NODE") statement
or
return ExecutionResult.Persist("A_NODE") statement
to implements the process of going back from the current process node to A NODE.I konw decision branch can do this ,but I want another way to realize this process. who can give me some advice,ungrateful!

@brucezlata
Copy link
Contributor

@MOwaisfarooq
Copy link

@brucezlata Can you please let me know how I can implement saga transaction. I am using EventPublish to forward the workflow step and in each step i have perform some database transaction through service injection. if error raises on any step, it will suspend the workflow and rollback my service transaction for current step only.

@brucezlata
Copy link
Contributor

brucezlata commented May 7, 2024

@MOwaisfarooq you can check the above link, for example, throw exception once there is any error in any of your steps (Tasks), then, compensate entire saga transaction (UndoEverything).

builder
    .StartWith(context => Console.WriteLine("Begin"))
        .Saga(saga => saga
            .StartWith<Task1>()
            .Then<Task2>()
            .Then<Task3>()
    )
        .CompensateWith<**UndoEverything**>()
    .Then(context => Console.WriteLine("End"));

@MOwaisfarooq
Copy link

If an error occurs in step B of the workflow, I suspend the workflow to publish this event later from the controller API. The _workflowStepDetailsService.UpdateTransactionForStepB has made a transaction in my table stepTable. I want to revert only the step B service transaction that updated the table. I don't want to undo everything, so that next time I can continue from step B after the error. For example, if I made an insertion in step A using _workflowStepDetailsService.CreateTransactionforStepA in my stepTable, I want to preserve that transaction and only undo the changes made by step B.

builder .StartWith(context => Console.WriteLine("Begin")) .UseDefaultErrorBehavior(WorkflowErrorHandling.Suspend) .Saga(saga => saga .StartWith<stepA>() .Then<stepB>() .Then<stepC>() ) .CompensateWith<**UndoEverything**>() .Then(context => Console.WriteLine("End"));
``

public class stepA: StepBodyAsync
{


    private readonly IWorkflowStepDetailsService _workflowStepDetailsService;

    public stepA(IWorkflowStepDetailsService workflowStepDetailsService)
    {
        _workflowStepDetailsService = workflowStepDetailsService;
    }

    public override async Task<ExecutionResult> RunAsync(IStepExecutionContext context)
    {

        if (!context.ExecutionPointer.EventPublished)
        {
            return ExecutionResult.WaitForEvent("StartWorkflowEvent", context.Workflow.Id, DateTime.Now);
        }

        var workflowsteprequest = (WorkFlowStepDetails)context.ExecutionPointer.EventData;
        await _workflowStepDetailsService.CreateTransactionforStepA(workflowsteprequest);

        return ExecutionResult.Next();
    }
}

``
public class stepB : StepBodyAsync
{
private readonly IWorkflowStepDetailsService _workflowStepDetailsService;

    public stepB: (IWorkflowStepDetailsService workflowStepDetailsService)
    {
        _workflowStepDetailsService = workflowStepDetailsService;
    }

    public override async Task<ExecutionResult> RunAsync(IStepExecutionContext context)
    {

        if (!context.ExecutionPointer.EventPublished)
        {
            return ExecutionResult.WaitForEvent("StartWorkflowEvent", context.Workflow.Id, DateTime.Now);
        }

        var workflowsteprequest = (WorkFlowStepDetails)context.ExecutionPointer.EventData;

        await _workflowStepDetailsService.UpdateTransactionForStepB(workflowsteprequest);

        return ExecutionResult.Next();
    }

}
``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants