Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersistedExecutionPointer's EventName and EventKey are shorter than PersistedEvent's ones #898

Open
vladimir-kovalyuk opened this issue Aug 20, 2021 · 2 comments · May be fixed by #908
Open

PersistedExecutionPointer's EventName and EventKey are shorter than PersistedEvent's ones #898

vladimir-kovalyuk opened this issue Aug 20, 2021 · 2 comments · May be fixed by #908

Comments

@vladimir-kovalyuk
Copy link

vladimir-kovalyuk commented Aug 20, 2021 •
edited

Describe the bug
EventName and EventKey properties of PersistedExecutionPointer are attributed as MaxLength(100), same properties of PersistedEvent are attributed as MaxLength(200).
When WFC attempts to save event name and event key to ExecutionPointer in WaitFor() operation that are the same as in PublishEvent() and exceed 100 symbols execution fails with error 'SQL Server Error : String or binary data would be truncated'.
At that PublishEvent is successful.

Expected behavior
PublishEvent() and WaitFor() should behave consistently so MaxLength on both PersistedExecutionPointer and PersistedEvent should be aligned and be at least 200 (taking into account production data).
@vladimir-kovalyuk
Copy link
Author

vladimir-kovalyuk commented Aug 20, 2021 •
edited

@danielgerlag I'll prepare PR soon. But I'm stuck a bit with fixing it as we currently unable to migrate to .Net 5 (stuck on 4.6.2) so fixing EF5 migrations in WorkflowCore.Persistence.SqlServer does not seem as a fix for us.
Our workaround would be to fix it manually on DB. But how to fix it in general for 4.x .Net?

@vladimir-kovalyuk
Copy link
Author

vladimir-kovalyuk commented Sep 4, 2021 •
edited

@danielgerlag please have a look #908 .
I created EF migration by targeting .Net 5 in WorkflowCore.Persistence.SqlServer. It didn't work out of the box.
I had to comment out the following lines in .csproj:

  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.EntityFrameworkCore.Tools.DotNet" Version="1.0.0-msbuild3-final" />
  </ItemGroup>

Maybe .csproj should reference the package with such name but appropriate version?
Please also note that I had to change the name of docker image as I hadn't found the one the source code refers.

@vladimir-kovalyuk vladimir-kovalyuk linked a pull request Sep 4, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align MaxLength of EventName and EventKey among entities. vladimir-kovalyuk/workflow-core
1 participant
@vladimir-kovalyuk