Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape '&' for Windows command line oAuth flow #253

Merged
merged 1 commit into from
May 29, 2024

Conversation

MatthiasScholzTW
Copy link
Contributor

Fixes #248.

PR escapes '&' character to enable oAuth flow for Windows operating systems.
Aside of the test @DominicBortmes as able to verify the fix for his context.

Copy link
Owner

@danielgtaylor danielgtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@danielgtaylor danielgtaylor merged commit 796c879 into danielgtaylor:main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is opening OAuth Authorization Url in Browser broken on windows due missing url escaping?
2 participants