Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #266: Add support of (un)registering global dynamic modules #267

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Closes #266: Add support of (un)registering global dynamic modules #267

wants to merge 13 commits into from

Conversation

daniluk4000
Copy link
Contributor

@daniluk4000 daniluk4000 commented Feb 22, 2022 •
edited

Closes #266

@vercel
Copy link

vercel bot commented Feb 22, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/danielroe/nuxt-typed-vuex/Auv7DtWVb7i4zR158aKKMRD59ApT
✅ Preview: Failed

[Deployment for 8fcc243 failed]

@lgtm-com
Copy link

lgtm-com bot commented Feb 22, 2022

This pull request introduces 1 alert when merging cf8be2e into 97c6cb7 - view on LGTM.com

new alerts:

  • 1 for Prototype-polluting assignment

@daniluk4000 daniluk4000 changed the title Closes #266: Add support of (un)registering global dynamic modules support Closes #266: Add support of (un)registering global dynamic modules Feb 22, 2022
@daniluk4000 daniluk4000 marked this pull request as ready for review February 24, 2022 16:58
@lgtm-com
Copy link

lgtm-com bot commented Feb 24, 2022

This pull request introduces 2 alerts when merging 668579e into 97c6cb7 - view on LGTM.com

new alerts:

  • 2 for Prototype-polluting assignment

@daniluk4000 @danielroe
Update docs/pages/en/2.accessor/2.dynamic-modules.md
c432b7b 
Co-authored-by: Daniel Roe <daniel@roe.dev>
@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2022

This pull request introduces 2 alerts when merging c432b7b into 97c6cb7 - view on LGTM.com

new alerts:

  • 2 for Prototype-polluting assignment

@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 2 alerts when merging 4ef4ea9 into 97c6cb7 - view on LGTM.com

new alerts:

  • 2 for Prototype-polluting assignment

@daniluk4000 daniluk4000 mentioned this pull request Mar 31, 2022
Closed
@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2022

This pull request introduces 2 alerts when merging 8fcc243 into 97c6cb7 - view on LGTM.com

new alerts:

  • 2 for Prototype-polluting assignment

@vercel
Copy link

vercel bot commented Apr 29, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
typed-vuex ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 4:35PM (UTC)

@lgtm-com
Copy link

lgtm-com bot commented Apr 29, 2022

This pull request introduces 2 alerts when merging 875df9f into bb5ff8d - view on LGTM.com

new alerts:

  • 2 for Prototype-polluting assignment

@Strongleong Strongleong mentioned this pull request Sep 16, 2022
Open
@lgtm-com
Copy link

lgtm-com bot commented Oct 5, 2022

This pull request introduces 2 alerts when merging e03904d into a16c245 - view on LGTM.com

new alerts:

  • 2 for Prototype-polluting assignment

@daniluk4000
Copy link
Contributor Author

@danielroe I tried to build it locally but it was failed. I think nuxt-typed-vuex needs vuex as dev dependency as well in order to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

Assignees

@daniluk4000 daniluk4000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Dynamically register and unregister a module
2 participants
@daniluk4000 @danielroe