Groups web page load fails: Persona has been deleted

[ThomaciousD]

Hi,

There is an issue when loading the groups page:

As seen from the logs, it looks like when a persona was attached to a group of users and that persona gets deleted, the group fails to load from the database:

danswer/backend/danswer/server/features/persona/models.py

Line 58 in 125d1a3

raise ValueError("Persona has been deleted")

INFO: "GET /manage/admin/user-group HTTP/1.1" 400 Bad Request
File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 294, in app
raw_response = await run_endpoint_function(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/fastapi/routing.py", line 193, in run_endpoint_function
return await run_in_threadpool(dependant.call, **values)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/starlette/concurrency.py", line 42, in run_in_threadpool
return await anyio.to_thread.run_sync(func, *args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/anyio/to_thread.py", line 33, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
return await future
^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 807, in run
result = context.run(func, *args)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/ee/danswer/server/user_group/api.py", line 27, in list_user_groups
return [UserGroup.from_model(user_group) for user_group in user_groups]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/ee/danswer/server/user_group/api.py", line 27, in
return [UserGroup.from_model(user_group) for user_group in user_groups]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/ee/danswer/server/user_group/models.py", line 57, in from_model
personas=[
^
File "/app/ee/danswer/server/user_group/models.py", line 58, in
PersonaSnapshot.from_model(persona)
File "/app/danswer/server/features/persona/models.py", line 54, in from_model
raise ValueError("Persona has been deleted")
ValueError: Persona has been deleted

I don't know if it helps, but on the postgre database the persona are still attached to the groups although they were deleted:

select persona_id from public.persona__user_group where persona_id in (select id from persona where deleted is true);

id

2
3
6
8
11
(5 rows)

A workaround has been found, to "undelete" the persona in the database:

update persona set deleted=false where deleted is true;

Then the Groups web page loads successfully but this is not what we want. We want to be able to delete personas.