Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output CLI inserts blank lines between entries within a snippet, not between snippets #45

Open
JoshuaKGoldberg opened this issue May 1, 2022 · 0 comments

Comments

@JoshuaKGoldberg
Copy link
Collaborator

JoshuaKGoldberg commented May 1, 2022

Here's an example of the CLI result from an early Learning TypeScript run:

⠦ 1/1: ch04-objects.asciidoc: 15/22 ch04-objects-444
ch04-objects-444: Unexpected TypeScript error: 0:15-19: Cannot find name 'poem'.

ch04-objects-444: Unexpected TypeScript error: 1:4-8: Cannot find name 'poem'.

ch04-objects-444: Unexpected TypeScript error: 3:4-8: Cannot find name 'poem'.
⠧ 1/1: ch04-objects.asciidoc: 16/22 ch04-objects-455
ch04-objects-455: Unexpected TypeScript error: 0:4-8: Cannot find name 'poem'.

ch04-objects-455: Expected TypeScript error was not produced: 0:9-14:  Property 'pages' does not exist on type 'PoemWithPages | PoemWithRhymes'. Property 'pages' does not exist on type 'PoemWithRhymes'.

Note that the last ch04-objects-444 report has a blank before it but not after. These would be a little easier to read if the blank lines were between snippets instead. How about something like the following?

⠦ 1/1: ch04-objects.asciidoc: 15/22 ch04-objects-444
ch04-objects-444: Unexpected TypeScript error: 0:15-19: Cannot find name 'poem'.
ch04-objects-444: Unexpected TypeScript error: 1:4-8: Cannot find name 'poem'.
ch04-objects-444: Unexpected TypeScript error: 3:4-8: Cannot find name 'poem'.

⠧ 1/1: ch04-objects.asciidoc: 16/22 ch04-objects-455
ch04-objects-455: Unexpected TypeScript error: 0:4-8: Cannot find name 'poem'.
ch04-objects-455: Expected TypeScript error was not produced: 0:9-14:  Property 'pages' does not exist on type 'PoemWithPages | PoemWithRhymes'. Property 'pages' does not exist on type 'PoemWithRhymes'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant