Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from webtreemap to foamtree #185

Open
nikolay-borzov opened this issue Apr 25, 2020 · 8 comments
Open

Switch from webtreemap to foamtree #185

nikolay-borzov opened this issue Apr 25, 2020 · 8 comments
Assignees
Milestone

Comments

@nikolay-borzov
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Some of the visualization features (e.g. coloring) are implemented by modifying webtreemap source. Other features source-map-explored needs are missing (tooltips, background coloring). foamtree has these features built-in. Also, implementing these features in webtreemap would take considerable effort.

Describe the solution you'd like
Replace webtreemap with foamtree for visualization

Describe alternatives you've considered
To add needed features to webtreemap we would have to make more of an effort.

Additional context
webpack-bundle-analyzer uses foamtree

@nikolay-borzov nikolay-borzov self-assigned this Apr 25, 2020
@nikolay-borzov nikolay-borzov added this to the 2.5.0 milestone Apr 25, 2020
@nikolay-borzov nikolay-borzov pinned this issue Apr 26, 2020
@nikolay-borzov
Copy link
Collaborator Author

Preview of current progress
sme-result-2020418-19588-1exzc9j.nf6l.html.zip

@danvk
Copy link
Owner

danvk commented May 19, 2020

@nikolay-borzov is it just me or is foamtree considerably slower during interactions?

@nikolay-borzov
Copy link
Collaborator Author

I think it's because of fade in/out effect. Here a version with disabled fade
sme-result-2020419-3004-15b2otx.wtd1.html.zip

@nikolay-borzov
Copy link
Collaborator Author

Added tooltip and reduced space between groups
sme-result-2020421-17760-1az7f1x.zqn8.html.zip

@nikolay-borzov
Copy link
Collaborator Author

Allow hiding bundles
sme-result-2020423-20696-1d20ect.r8l5.html.zip

@danvk
Copy link
Owner

danvk commented May 26, 2020

@nikolay-borzov it's definitely zippier w/o the fade in/out effect. Could you share a visualization of that same set of source maps using webtreemap for comparison?

@danvk
Copy link
Owner

danvk commented May 26, 2020

The hierarchy is also a bit less clear to me. Looking at this visualization, it's only apparent when you hover and look at the percentages that everything you see is part of big.js (it looks like three independent blocks at the same level of hierarchy):

image

@nikolay-borzov
Copy link
Collaborator Author

nikolay-borzov commented May 26, 2020

@nikolay-borzov it's definitely zippier w/o the fade in/out effect. Could you share a visualization of that same set of source maps using webtreemap for comparison?

You can get it if you run

node bin/cli.js tests/data/*.*

sme-result-2020428-18356-16x6o78.4u3k.html.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants