Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "File not Found" error for Azure BlobStorage and AWS S3 bindings #2526

Closed
federicocodo opened this issue Feb 13, 2023 · 3 comments · Fixed by #3223
Closed

Improve "File not Found" error for Azure BlobStorage and AWS S3 bindings #2526

federicocodo opened this issue Feb 13, 2023 · 3 comments · Fixed by #3223
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed size/XS 2 days of work triaged/resolved
Milestone

Comments

@federicocodo
Copy link

federicocodo commented Feb 13, 2023

As the previous issue (#2374) is it possible to add a similar line of code, added for LocalStorage binding, also for other storages like Azure BlobStorage, AWS S3, ecc...?

if os.IsNotExist(err) {
    return nil, fmt.Errorf("file not found: %s", absPath)
}

Currently for Azure BlobStorage I get this error:
image
This is all because I'm running a multi-storage service and trying to manage all responses.
Thanks in advance.

@federicocodo federicocodo added the kind/bug Something isn't working label Feb 13, 2023
@berndverst
Copy link
Member

Sure, contributions are welcome. Please note that in Dapr 1.10 and going forward we use a completely different Azure Blob Storage SDK. So you will not be able to reproduce this exact error message there.

@berndverst berndverst added help wanted Extra attention is needed and removed kind/bug Something isn't working labels Feb 13, 2023
@berndverst berndverst changed the title Manage Azure BlobStorage and AWS S3 bindings file not found Improve "File not Found" error for Azure BlobStorage and AWS S3 bindings Feb 13, 2023
@berndverst berndverst added good first issue Good for newcomers size/XS 2 days of work triaged/resolved labels Feb 13, 2023
@berndverst berndverst added this to the v1.11 milestone Feb 13, 2023
@berndverst berndverst modified the milestones: v1.11, v1.12 May 30, 2023
@artursouza artursouza removed this from the v1.12 milestone Jun 30, 2023
@artursouza
Copy link
Member

Removing from 1.12, if anyone from the community creates a PR, we can bring it back.

@sadath-12
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed size/XS 2 days of work triaged/resolved
Projects
None yet
4 participants