Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Switch from docker.io to ghcr.io within the Helm default yaml values file #6413

Closed
cmoulliard opened this issue May 26, 2023 · 5 comments

Comments

@cmoulliard
Copy link
Contributor

In what area(s)?

/area helm chart

Describe the feature

I suggest to switch from the default registry docker.io to ghcr.io to avoid on some kubernetes clusters to get the docker rate limit issue

Such a change will just need to change the following parameters within the helm default values YAML file

dapr_dashboard:
  image:
     registry: ghcr.io/dapr
...
global
    registry: docker.io/daprio

NOTE: Such a change will also help the users installing Dapr using the upcoming OLM Operator as the operator is installing Dapr using Dapr Helm chart

Release Note

RELEASE NOTE: UPDATE Helm chart global registry default parameter changed to use ghcr.io instead of docker.io

@artursouza
Copy link
Member

I support this for Helm and CLI.

@artursouza artursouza added this to the v1.12 milestone May 31, 2023
@artursouza
Copy link
Member

Cc @mukundansundar @yaron2

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale Issues and PRs without response label Jul 30, 2023
@dapr-bot
Copy link
Collaborator

dapr-bot commented Aug 6, 2023

This issue has been automatically closed because it has not had activity in the last 67 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@dapr-bot dapr-bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2023
@artursouza artursouza removed the stale Issues and PRs without response label Oct 5, 2023
@artursouza artursouza reopened this Oct 5, 2023
@artursouza artursouza modified the milestones: v1.12, v1.13 Oct 5, 2023
@artursouza artursouza added the good first issue Good for newcomers label Oct 5, 2023
@JoshVanL
Copy link
Contributor

Closed as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants