Daprd Metrics Breaking Change

[JoshVanL]

With #6919 merged, Dapr has a breaking change to the metrics which are exposed. This can be seen with the failing version skew metrics test https://github.com/dapr/dapr/actions/runs/7169171492/job/19518959642.

As a project, we need to make the decision as to whether we accept this as a breaking change, or introduce a flag to revert the previous behaviour.

[ItalyPaleAle]

The issue isn't #6919, it's totally unrelated.

The issue is #6945 which removed the deprecated RenameReminder test. This is expected and the test itself needs to change:

This is now failing because the API endpoint doesn't exist anymore. Dapr considers that call to be service invocation, but there's no app ID in the request so it doesn't know what to invoke.

[mukundansundar]

The issue isn't #6919, it's totally unrelated.

The issue is #6945 which removed the deprecated RenameReminder test. This is expected and the test itself needs to change:

This is now failing because the API endpoint doesn't exist anymore. Dapr considers that call to be service invocation, but there's no app ID in the request so it doesn't know what to invoke.

In this test http_metrics also fails and that is the main point of this issue. For tackling the rename reminder removal, there is a separate issue.

[ItalyPaleAle]

Got it. In any case, the feature flag is going to be added but the test needs to change regardless as the new behavior will be the default

[filintod]

it would be good to have a flag to keep the old metrics behavior. as a DevOp on call relying on metrics/labels for alerts I would not be very happy when these have changed under my feet without a way out

[yaron2]

Maybe it's best we default to the old behavior and introduce a config option of lowCardinality=true/false

[artursouza]

Does this PR also re-introduces the regex rewrite we had? I remember people using that to keep the metrics URLs without PII information.

[ItalyPaleAle]

Were those the only concerns that forced the creation of this PR?

• Regex rewrite has always been available. Of course the regex themselves are different with the old and new formats.
• The new format by default does not emit PII