append app token to outgoing calls, if it is provided #7404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Kelly <gatedlogic@live.com>
|
@vermillionsword see the minor linter error |
|
@vermillionsword please fix DCO. |
Signed-off-by: Ryan Kelly <gatedlogic@live.com>
Fixed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7404 +/- ##
==========================================
- Coverage 62.39% 62.36% -0.04%
==========================================
Files 240 240
Lines 22156 22159 +3
==========================================
- Hits 13825 13820 -5
- Misses 7173 7179 +6
- Partials 1158 1160 +2 ☔ View full report in Codecov by Sentry. |
ItalyPaleAle
approved these changes
Jan 18, 2024
whytem
pushed a commit
to whytem/dapr
that referenced
this pull request
Jan 22, 2024
* append app token to outgoing calls, if it is provided Signed-off-by: Ryan Kelly <gatedlogic@live.com> * use declare and assign syntax Signed-off-by: Ryan Kelly <gatedlogic@live.com> --------- Signed-off-by: Ryan Kelly <gatedlogic@live.com> Co-authored-by: Ryan Kelly <gatedlogic@live.com>
elena-kolevska
pushed a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 24, 2024
* append app token to outgoing calls, if it is provided Signed-off-by: Ryan Kelly <gatedlogic@live.com> * use declare and assign syntax Signed-off-by: Ryan Kelly <gatedlogic@live.com> --------- Signed-off-by: Ryan Kelly <gatedlogic@live.com> Co-authored-by: Ryan Kelly <gatedlogic@live.com>
elena-kolevska
added a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 24, 2024
)" This reverts commit b1215d5.
elena-kolevska
added a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 24, 2024
…dapr#7404)"" This reverts commit 12406b9.
elena-kolevska
pushed a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 25, 2024
* append app token to outgoing calls, if it is provided Signed-off-by: Ryan Kelly <gatedlogic@live.com> * use declare and assign syntax Signed-off-by: Ryan Kelly <gatedlogic@live.com> --------- Signed-off-by: Ryan Kelly <gatedlogic@live.com> Co-authored-by: Ryan Kelly <gatedlogic@live.com> Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska
added a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 25, 2024
)" This reverts commit b1215d5. Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska
added a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 25, 2024
…dapr#7404)"" This reverts commit 12406b9. Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska
pushed a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 25, 2024
* append app token to outgoing calls, if it is provided Signed-off-by: Ryan Kelly <gatedlogic@live.com> * use declare and assign syntax Signed-off-by: Ryan Kelly <gatedlogic@live.com> --------- Signed-off-by: Ryan Kelly <gatedlogic@live.com> Co-authored-by: Ryan Kelly <gatedlogic@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR appends the App API Token to calls made using the transparent proxy functionality provided in grpc_proxy.go
It will only be appended if the environment variable exists
Issue reference
#7344
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: