-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Standardization: Configuration API #7485
Comments
Hi @cicoyle, does this issue still need to be worked on? I haven't contributed to the project yet, but looking forward to working on this one, if possible. |
Yes @stackanthony, this is available to be worked on. I'm happy to hear you are interested in contributing to Dapr. Please clone this issue and assign yourself to it. Please lmk if you need any assistance along the way 🙂 |
Forsure, will do. I'll need some time to get acclimated to the codebase. Will let you know if I have any questions. P.S. - I worked at HashiCorp too, awesome to see someone from there contributing to the project @cicoyle |
When you say clone this issue, how exactly should I do this? I've never done something like cloning an issue, only a repo lol. Can't find anything online about it either, maybe I misunderstood. @cicoyle |
@stackanthony - clone as in, create a new issue, copy/paste the content, then assign your name to it :) Ah cool - I was at HashiCorp for a while, and am very happy to be at Diagrid now |
Richer errors in Dapr for the Configuration API.
Note: Please clone this issue and assign the clone of this issue to yourself if you would like to contribute to the error standardization efforts.
Scope of work
Definition of done
Keep in mind
Unless a major version is being released and there is a solid reason for introducing backwards incompatibility, we can't change the API, meaning the HTTP and gRPC status codes, and the error codes must stay the same. An exception to this is the gRPC
StatusCode.UNKNOWN
which should be converted to a specific status.See the kit errors pkg README for another usage example. For each error being updated, you can use the following helper functions to add error details, see the kit errors pkg for more details:
WithHelpLink()
WithHelp()
WithErrorInfo()
- RequiredWithFieldViolation()
WithDetails()
Reference PRs
Existing error standardization for:
The text was updated successfully, but these errors were encountered: