Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add custom environment variable to dapr control plane #7182

Closed
filintod opened this issue Nov 14, 2023 · 1 comment · Fixed by #7183
Closed

Add ability to add custom environment variable to dapr control plane #7182

filintod opened this issue Nov 14, 2023 · 1 comment · Fixed by #7183
Assignees
Labels
kind/bug Something isn't working

Comments

@filintod
Copy link
Contributor

In what area(s)?

/area runtime

Need a way to specify soft memory limit (ie GOMEMLIMIT) to dapr system. This comes handy when setting memory limit on container so the Go runtime can try to release memory before OOMKilled happens. Another options would be to add it in code https://pkg.go.dev/runtime/debug#SetMemoryLimit but this way is configurable by the customer directly as adding it in code will still require some kind of user interaction (ie set it at 90% or 95%, etc).

What version of Dapr?

1.1.x
1.0.x
edge: output of git describe --dirty

Expected Behavior

I should be able to say, in the corresponding chart:

extraEnvVars:
- name: GOMEMLIMIT
  value: 900MiB

and this is set to the corresponding deployment/sts for the container in the chart.

Actual Behavior

There is no option for this

Steps to Reproduce the Problem

Release Note

RELEASE NOTE:

@filintod filintod added the kind/bug Something isn't working label Nov 14, 2023
@filintod
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant