Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDKs] DAPR_API_TOKEN env variable #3921

Closed
Tracked by #7410
hhunter-ms opened this issue Dec 21, 2023 · 9 comments
Closed
Tracked by #7410

[SDKs] DAPR_API_TOKEN env variable #3921

hhunter-ms opened this issue Dec 21, 2023 · 9 comments
Assignees
Labels
content/missing-information More information requested or needed
Milestone

Comments

@hhunter-ms
Copy link
Collaborator

What content needs to be created or modified?
Check and make sure this is documented across all the SDKs (open PRs in sdk repos)

Where should the new material be placed?
SDK docs

The associated pull request from dapr/dapr, dapr/components-contrib, or other Dapr code repos
dapr/js-sdk#547

@hhunter-ms hhunter-ms added the content/missing-information More information requested or needed label Dec 21, 2023
@hhunter-ms hhunter-ms added this to the 1.13 milestone Dec 21, 2023
@hhunter-ms
Copy link
Collaborator Author

@msfussell ok to close this? or did we need this in other SDKs?

@elena-kolevska
Copy link
Contributor

I just created an issue for it in python-sdk dapr/python-sdk#653.
Sending a PR in a bit.

@elena-kolevska
Copy link
Contributor

Here's the PR: dapr/python-sdk#654. It's a very small update.

@msfussell
Copy link
Member

@elena-kolevska - Does this need to be done with other SDKs?

@elena-kolevska
Copy link
Contributor

elena-kolevska commented Jan 12, 2024

The only code change we did was in the JS sdk, all the other ones already had this feature, but not all of them had the docs properly updated. Here's a list:


  • php-sdk - Missing documentation - decided we're not doing it
  • cpp-sdk - Doesn't support this feature
  • rust-sdk - Doesnt support this feature

@cicoyle would you be able to help with the java-sdk docs for this? (I've never worked with this sdk and don't have the environment set up to test). I would suggest copying the Initialising the client section from the python-sdk docs and adapting the snippets to Java.

@elena-kolevska
Copy link
Contributor

I added this PR for the Java sdk, but since I'm not very familiar with the code I'm gonna rely on Cassie or someone else to confirm it's correct.

@cicoyle
Copy link
Contributor

cicoyle commented Jan 18, 2024

oops, I missed your ping on here. thanks @elena-kolevska

@elena-kolevska
Copy link
Contributor

I think we can now consider this done.

@hhunter-ms
Copy link
Collaborator Author

@elena-kolevska sounds good - closing as resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content/missing-information More information requested or needed
Projects
None yet
Development

No branches or pull requests

4 participants