Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cascade Terminate/Purge for workflow #1226

Closed
Tracked by #7410
shivamkm07 opened this issue Jan 17, 2024 · 4 comments · Fixed by #1243
Closed
Tracked by #7410

Cascade Terminate/Purge for workflow #1226

shivamkm07 opened this issue Jan 17, 2024 · 4 comments · Fixed by #1243
Assignees
Milestone

Comments

@shivamkm07
Copy link
Contributor

shivamkm07 commented Jan 17, 2024

Describe the feature

Cascade terminate/purge feature for workflow has been added in Dapr runtime. It is enabled by default and can be disabled by passing non_recursive=True in the terminate/purge request.

SDK needs to expose this option to customer.

Reference:

  1. Cascade terminate/Purge Workflow Support dapr#7340
  2. Cascade Terminate and Purge Support microsoft/durabletask-go#47
  3. Support Cascade Terminate/Purge microsoft/durabletask-dotnet#260

Release Note

RELEASE NOTE:

@shivamkm07 shivamkm07 added the kind/enhancement New feature or request label Jan 17, 2024
@shivamkm07
Copy link
Contributor Author

PR to support cascade terminate/purge in durabletask-dotnet: microsoft/durabletask-dotnet#262

After this gets merged, will create the PR to surface the option here.

@shivamkm07
Copy link
Contributor Author

/assign

@halspang
Copy link
Contributor

I've added the breaking change label here because this is technically a change in core behavior that the user can't opt into. I do understand that this is the desired path so it's more of a bugfix than anything else, but we need to advertise that.

@shivamkm07
Copy link
Contributor Author

Closed by #1243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants