Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor timers and reminders should accept empty period parameter #535

Closed
heunghingwan opened this issue Oct 15, 2023 · 0 comments · Fixed by #536
Closed

Actor timers and reminders should accept empty period parameter #535

heunghingwan opened this issue Oct 15, 2023 · 0 comments · Fixed by #536
Assignees
Labels
bug Something isn't working

Comments

@heunghingwan
Copy link
Contributor

Expected Behavior

period is an optional parameter that sets time interval between two consecutive callback invocations. When specified in ISO 8601-1 duration format, you can also configure the number of repetition in order to limit the total number of callback invocations. If period is omitted, the callback will be invoked only once.
link

Actual Behavior

throw TypeError: Cannot read properties of undefined (reading 'toString')

Steps to Reproduce the Problem

await actor.registerActorReminder("update", Temporal.Duration.from({ seconds: 5 }), undefined, undefined, 100)
This should start a one-time reminder after 5 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants