Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Support Cascade Terminate/Purge feature for Dapr Workflow #661

Closed
Tracked by #7410
shivamkm07 opened this issue Jan 17, 2024 · 3 comments · Fixed by #662
Closed
Tracked by #7410

[FEATURE REQUEST] Support Cascade Terminate/Purge feature for Dapr Workflow #661

shivamkm07 opened this issue Jan 17, 2024 · 3 comments · Fixed by #662
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@shivamkm07
Copy link
Contributor

shivamkm07 commented Jan 17, 2024

Describe the feature

Cascade terminate/purge feature for workflow has been added in Dapr runtime. It is enabled by default and can be disabled by passing non_recursive=True in the terminate/purge request.

SDK needs to expose this option to customer.

Reference:

  1. Cascade terminate/Purge Workflow Support dapr#7340
  2. Cascade Terminate and Purge Support microsoft/durabletask-go#47
  3. Include recursive flag in terminate_orchestration microsoft/durabletask-python#27

Release Note

RELEASE NOTE:

@shivamkm07 shivamkm07 added the kind/enhancement New feature or request label Jan 17, 2024
@shivamkm07
Copy link
Contributor Author

/assign

@berndverst
Copy link
Member

berndverst commented Jan 19, 2024

Never mind - ignore my comment. I see this is a feature for workflow that must go into the core SDK.

Keep in mind that we are 2 days beyond code freeze. Please have your PR ready (all feedback addressed etc) next week to ensure this will be in the next SDK release.

@berndverst berndverst added dapr-ext-workflow kind/enhancement New feature or request and removed kind/enhancement New feature or request dapr-ext-workflow labels Jan 19, 2024
@shivamkm07
Copy link
Contributor Author

Never mind - ignore my comment. I see this is a feature for workflow that must go into the core SDK.

Keep in mind that we are 2 days beyond code freeze. Please have your PR ready (all feedback addressed etc) next week to ensure this will be in the next SDK release.

@berndverst The PR is updated and open for review now. Please take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants